fix: include stdout diagnostics when stderr is empty on swift package failure#255
Merged
cameroncooke merged 1 commit intogetsentry:mainfrom Mar 2, 2026
Conversation
… failure SPM writes compiler diagnostics to stdout, not stderr. The ?? operator does not treat empty string as falsy, so when stderr is "" the diagnostics in stdout were never included in the error response. Switching to || fixes the fallback for all three affected tools. Fixes getsentry#243
Collaborator
|
@doovers Thanks for the contribution and good catch! |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swift_package_build,swift_package_test, andswift_package_cleanswallowing compiler diagnostics on failure??operator does not treat""as falsy, so when stderr is empty the stdout diagnostics were silently dropped||fixes the fallback so diagnostics are always included in the error responseChanges
swift_package_build.ts,swift_package_test.ts,swift_package_clean.ts:result.error ?? result.output→result.error || result.outputswift_package_buildandswift_package_testTest plan
npx vitest run src/mcp/tools/swift-package/__tests__/swift_package_build.test.ts src/mcp/tools/swift-package/__tests__/swift_package_test.test.tslet broken: DOESNOTEXIST = 42, runnode build/cli.js swift-package build --package-path <path>— full diagnostics with file/line/col now appear in the error responseFixes #243